kou commented on code in PR #37602:
URL: https://github.com/apache/arrow/pull/37602#discussion_r1318040296
##########
cpp/src/parquet/CMakeLists.txt:
##########
@@ -114,12 +114,13 @@ else()
set(ARROW_LIBRARIES_FOR_STATIC_TESTS arrow_testing_shared arrow_shared)
endif()
-set(PARQUET_MIN_TEST_LIBS ${ARROW_GTEST_GTEST_MAIN} ${ARROW_GTEST_GTEST}
Boost::headers)
+set(PARQUET_MIN_TEST_LIBS ${ARROW_GTEST_GMOCK} ${ARROW_GTEST_GTEST}
Review Comment:
Yes. `ARROW_GTEST_GMOCK` is the main change. `list(APPEND` is for modenizing
our CMake code.
It's not related to this fix. I'm modernizing our CMake code step-by-step
when I touch related CMake code.
If you don't like it, I can remove the change from this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
