AlenkaF commented on code in PR #37558:
URL: https://github.com/apache/arrow/pull/37558#discussion_r1318381230
##########
python/pyarrow/tests/test_fs.py:
##########
@@ -703,6 +703,10 @@ def test_get_file_info_with_selector(fs, pathfn):
# on the s3fs/fsspec version combo, it includes the base_dir
# (https://github.com/dask/s3fs/issues/393)
assert (len(infos) == 4) or (len(infos) == 5)
+ elif fs.type_name in ["py::fsspec+file", 'py::fsspec+memory']:
+ # fsspec also lists root dir
+ # GH-37555
Review Comment:
This is a very important info, thanks! =)
Instead of updating the test I will work around it in FSSpecHandler 👍
##########
python/pyarrow/tests/test_fs.py:
##########
@@ -703,6 +703,10 @@ def test_get_file_info_with_selector(fs, pathfn):
# on the s3fs/fsspec version combo, it includes the base_dir
# (https://github.com/dask/s3fs/issues/393)
assert (len(infos) == 4) or (len(infos) == 5)
+ elif fs.type_name in ["py::fsspec+file", 'py::fsspec+memory']:
+ # fsspec also lists root dir
+ # GH-37555
Review Comment:
This is a very important info, thanks! =)
Instead of updating the test I will work around it in FSSpecHandler 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
