alamb commented on issue #4733: URL: https://github.com/apache/arrow-rs/issues/4733#issuecomment-1710141845
While working on https://github.com/apache/arrow-rs/issues/4788 I had an idea for porting the comparison kernel test that I think would be more satisfying than porting the existing tests as well as adding coverage. # Proposal Add "fuzz" testing to the comparison kernels that basically did: 1. Make a random inputs, and compute (using rust code) the expected output 2. Run the comparison kernel 3. Compare the output to the expected output We could implement this fuzz testing in several PRs and then remove the old kernels # Missing Coverage I believe the existing kernels are missing the following coverage: 1. Tests for arrays with more than 64 values. I found [special case code](https://github.com/apache/arrow-rs/blob/6fdbc263b08fea0858b662e8d792f88268d9e741/arrow-ord/src/cmp.rs#L365-L398) for iterating through values 64 at a time (and then remainder) but I didn't see any tests that actually tested more than 64 values 2. Dictionary arrays where NULL inputs have invalid keys (the root cause of https://github.com/apache/arrow-rs/issues/4788) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
