lidavidm commented on code in PR #907:
URL: https://github.com/apache/arrow-adbc/pull/907#discussion_r1318617798
##########
c/driver/snowflake/snowflake_test.cc:
##########
@@ -184,28 +184,37 @@ class SnowflakeStatementTest : public ::testing::Test,
}
void TestSqlIngestInterval() { GTEST_SKIP(); }
+ void TestSqlIngestDuration() { GTEST_SKIP(); }
protected:
- void ValidateIngestedTimestampData(struct ArrowArrayView* values,
- enum ArrowTimeUnit unit,
- const char* timezone) override {
- std::vector<std::optional<int64_t>> expected;
- switch (unit) {
- case NANOARROW_TIME_UNIT_SECOND:
- expected = {std::nullopt, -42, 0, 42};
- break;
- case NANOARROW_TIME_UNIT_MILLI:
- expected = {std::nullopt, -42000, 0, 42000};
- break;
- case NANOARROW_TIME_UNIT_MICRO:
- expected = {std::nullopt, -42, 0, 42};
- break;
- case NANOARROW_TIME_UNIT_NANO:
- expected = {std::nullopt, -42, 0, 42};
+ void ValidateIngestedTemporalData(struct ArrowArrayView* values, ArrowType
type,
+ enum ArrowTimeUnit unit,
+ const char* timezone) override {
+ switch (type) {
+ case NANOARROW_TYPE_TIMESTAMP: {
+ std::vector<std::optional<int64_t>> expected;
+ switch (unit) {
+ case NANOARROW_TIME_UNIT_SECOND:
+ expected = {std::nullopt, -42, 0, 42};
+ break;
+ case NANOARROW_TIME_UNIT_MILLI:
+ expected = {std::nullopt, -42000, 0, 42000};
+ break;
+ case NANOARROW_TIME_UNIT_MICRO:
+ expected = {std::nullopt, -42, 0, 42};
+ break;
+ case NANOARROW_TIME_UNIT_NANO:
+ expected = {std::nullopt, -42, 0, 42};
+ break;
+ }
+ ASSERT_NO_FATAL_FAILURE(
+ adbc_validation::CompareArray<std::int64_t>(values, expected));
break;
+ }
+ default:
+ ASSERT_TRUE(false) << "ValidateIngestedTemporalData not implemented
for type "
Review Comment:
I think `FAIL()` is meant for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
