yordan-pavlov commented on a change in pull request #9064:
URL: https://github.com/apache/arrow/pull/9064#discussion_r551621749
##########
File path: rust/parquet/src/file/serialized_reader.rs
##########
@@ -137,6 +137,22 @@ impl<R: 'static + ChunkReader> SerializedFileReader<R> {
metadata,
})
}
+
+ pub fn filter_row_groups(
Review comment:
there is another possibility - I have just noticed
`FilePageIterator::with_row_groups` which could be used to filter row groups
based on a list of row group indexes; this could replace the
`filter_row_groups` method but would require the row group indexes to be passed
down all the way to `build_for_primitive_type_inner` where `FilePageIterator`
is created; this could be done through a new field in
`ArrayReaderBuilderContext`.
It's a deeper change but would mean that `filter_row_groups` method is no
longer necessary. @sunchao do you think this would be a better way to go about
filtering of row groups?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
