pitrou commented on PR #37610: URL: https://github.com/apache/arrow/pull/37610#issuecomment-1710427210
> If I understand correctly we compile the `_avx2.cc` files with both AVX2 and BMI2 enabled. Doesn't this meant that any function in any `_avx2.cc` file may contain a `bmi2` operation? Nit: only two `_avx2.cc` files are concerned, those that use explicit BMI2 intrinsics. > In other words, even if we examine a file and determine it has no explicit `pext`, `pdep`, etc. then wouldn't it still be possible for the compiler to insert those instructions itself as an implicit operation? Indeed. But this PR introduces matching runtime guards when calling those functions, so this shouldn't be a problem. Am I missing another concern here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
