kevingurney commented on PR #37616: URL: https://github.com/apache/arrow/pull/37616#issuecomment-1710597260
Hi @RANJITHROSAN17, thank you for contributing to the MATLAB interface to Arrow! A few notes: 1. It looks like the code for your pull request is incomplete. In order to add a `NumRows` property, you will most likely need to add a new `getNumRows` method to the `RecordBatch` C++ Proxy class and then call this Proxy method from a `get.NumRows` method on the MATLAB `arrow.tabular.RecordBatch` class. You can see the way we are planning to implement `NumRows` for `arrow.tabular.Table` for reference ([C++ Proxy `getNumRows` member function](https://github.com/apache/arrow/compare/main...mathworks:arrow:GH-37571?expand=1#diff-c5741330988b204b0475a09c4d41b1b6a5263000c28a66be3f6efd17935ea25fR87) and [MATLAB get.NumRows method](https://github.com/apache/arrow/compare/main...mathworks:arrow:GH-37571?expand=1#diff-e41a88d788ec32e16a75dba6570728e08411a0fb99fb86705ff39a58223858fdR46)] 2. If you haven't already, please refer to the [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/index.html#guide-introduction) for helpful tips on getting started contributing to the Apache Arrow project. 3. Pull request titles should follow the format: `GH-<github-issue-id>: [<component>] <description>` in order for automatic linking of a pull request to a GitHub issue to occur. For example, the title for this pull request should be: `GH-37592: [MATLAB] Add NumRows property to arrow.tabular.RecordBatch`. 4. In general, it is a good idea for you to take ownership of an issue before you start working on it to inform others. You can take a GitHub issue by commenting `take` on the issue. For example, see: https://github.com/apache/arrow/issues/37448#issuecomment-1698071825. Please don't hesitate to ask questions if you run into issues. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
