tolleybot commented on code in PR #34616: URL: https://github.com/apache/arrow/pull/34616#discussion_r1319123464
########## cpp/src/arrow/dataset/file_parquet.cc: ########## @@ -622,10 +640,36 @@ Result<std::shared_ptr<FileWriter>> ParquetFileFormat::MakeWriter( auto parquet_options = checked_pointer_cast<ParquetFileWriteOptions>(options); std::unique_ptr<parquet::arrow::FileWriter> parquet_writer; - ARROW_ASSIGN_OR_RAISE(parquet_writer, parquet::arrow::FileWriter::Open( - *schema, default_memory_pool(), destination, - parquet_options->writer_properties, - parquet_options->arrow_writer_properties)); + +#ifdef PARQUET_REQUIRE_ENCRYPTION Review Comment: I've added a test case WriteWithEncryptionConfigNotSupported in the TestParquetFileSystemDataset class. This test specifically checks the behavior when parquet_encrypt_config is set and PARQUET_REQUIRE_ENCRYPTION is not defined. It expects a Status::NotImplemented -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
