korowa opened a new issue, #7504:
URL: https://github.com/apache/arrow-datafusion/issues/7504

   ### Is your feature request related to a problem or challenge?
   
   Follow up based on 
https://github.com/apache/arrow-datafusion/pull/7459#pullrequestreview-1616135946
   
   Displaying statistics in executions plans as a default behaviour is nice to 
have feature. The only challenge here is to enable/implement it without 
significantly growing burden of tests maintenance, as some of them, in 
different parts of codebase, rely on text representation on execution plan, and 
it doesn't seem convenient to fix random tests across multiple packages in case 
of e.g. statistics calculation related changes.
   
   ### Describe the solution you'd like
   
   One possible solution might be to explicitly disabling`show_statistics` 
setting everywhere in tests, except for cases requiring statistics in output.
   
   Another one could be to have a common normalizer (like we already have in 
[sqllogictests](https://github.com/apache/arrow-datafusion/blob/4d4451294629940d340160cdd06be273139728b4/datafusion/sqllogictest/src/engines/datafusion_engine/normalize.rs#L32)
 and in 
[core/tests/sql](https://github.com/apache/arrow-datafusion/blob/4d4451294629940d340160cdd06be273139728b4/datafusion/core/tests/sql/mod.rs#L806)
 for datafiles path replacement) which could be accessible across all tests and 
would allow to replace statistics with empty or remove it from plan text. In 
this case the `datafusion.explain.show_statistics` setting is not needed 
anymore.
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to