Dandandan commented on code in PR #7488: URL: https://github.com/apache/arrow-datafusion/pull/7488#discussion_r1319441330
########## datafusion/sqllogictest/test_files/union.slt: ########## @@ -466,8 +466,8 @@ UnionExec ----AggregateExec: mode=FinalPartitioned, gby=[Int64(1)@0 as Int64(1)], aggr=[] ------CoalesceBatchesExec: target_batch_size=8192 --------RepartitionExec: partitioning=Hash([Int64(1)@0], 4), input_partitions=4 -----------RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=1 -------------AggregateExec: mode=Partial, gby=[1 as Int64(1)], aggr=[] +----------AggregateExec: mode=Partial, gby=[1 as Int64(1)], aggr=[] Review Comment: Maybe unnecessary parallelism could be improved with a simple statistics-based rule: if the input size is less than the batch size, nothing could be gained from the increased parallelism. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
