vrongmeal commented on PR #4795:
URL: https://github.com/apache/arrow-rs/pull/4795#issuecomment-1711561126
> Have you run the benchmarks for this change?
```
❯ cargo bench --bench csv_reader
Compiling arrow-csv v46.0.0 (/Users/vrongmeal/Projects/arrow-rs/arrow-csv)
Compiling arrow v46.0.0 (/Users/vrongmeal/Projects/arrow-rs/arrow)
Finished bench [optimized] target(s) in 4.92s
Running benches/csv_reader.rs
(target/release/deps/csv_reader-dadff296bc34e88b)
4096 u64(0) - 128 time: [238.26 µs 238.78 µs 239.28 µs]
change: [+6.9565% +7.2459% +7.5214%] (p = 0.00 <
0.05)
Performance has regressed.
Found 7 outliers among 100 measurements (7.00%)
3 (3.00%) low mild
2 (2.00%) high mild
2 (2.00%) high severe
4096 u64(0) - 1024 time: [208.08 µs 208.18 µs 208.29 µs]
change: [+7.0050% +7.4168% +7.7855%] (p = 0.00 <
0.05)
Performance has regressed.
Found 10 outliers among 100 measurements (10.00%)
3 (3.00%) low mild
4 (4.00%) high mild
3 (3.00%) high severe
4096 u64(0) - 4096 time: [214.62 µs 215.65 µs 216.80 µs]
change: [+7.4572% +7.8687% +8.3141%] (p = 0.00 <
0.05)
Performance has regressed.
Found 30 outliers among 100 measurements (30.00%)
16 (16.00%) low severe
2 (2.00%) low mild
1 (1.00%) high mild
11 (11.00%) high severe
4096 i64(0) - 128 time: [266.09 µs 266.39 µs 266.66 µs]
change: [+5.7398% +5.8570% +5.9624%] (p = 0.00 <
0.05)
Performance has regressed.
4096 i64(0) - 1024 time: [237.48 µs 238.31 µs 239.60 µs]
change: [+5.0834% +5.3245% +5.6549%] (p = 0.00 <
0.05)
Performance has regressed.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) high mild
3 (3.00%) high severe
4096 i64(0) - 4096 time: [245.08 µs 246.59 µs 248.04 µs]
change: [+6.1555% +6.7570% +7.3428%] (p = 0.00 <
0.05)
Performance has regressed.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild
4096 f32(0) - 128 time: [257.63 µs 257.84 µs 258.05 µs]
change: [+7.4875% +7.5943% +7.6967%] (p = 0.00 <
0.05)
Performance has regressed.
Found 11 outliers among 100 measurements (11.00%)
2 (2.00%) low mild
8 (8.00%) high mild
1 (1.00%) high severe
4096 f32(0) - 1024 time: [229.77 µs 229.95 µs 230.15 µs]
change: [+8.2822% +8.4132% +8.5422%] (p = 0.00 <
0.05)
Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
4096 f32(0) - 4096 time: [238.71 µs 239.11 µs 239.45 µs]
change: [+6.0796% +6.6259% +7.0354%] (p = 0.00 <
0.05)
Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) low mild
2 (2.00%) high mild
4096 f64(0) - 128 time: [280.21 µs 280.50 µs 280.81 µs]
change: [+7.8352% +7.9521% +8.0750%] (p = 0.00 <
0.05)
Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild
4096 f64(0) - 1024 time: [252.86 µs 252.96 µs 253.07 µs]
change: [+7.8311% +7.9334% +8.0289%] (p = 0.00 <
0.05)
Performance has regressed.
Found 7 outliers among 100 measurements (7.00%)
3 (3.00%) high mild
4 (4.00%) high severe
4096 f64(0) - 4096 time: [266.61 µs 267.84 µs 269.00 µs]
change: [+4.7965% +5.3015% +5.8712%] (p = 0.00 <
0.05)
Performance has regressed.
Found 22 outliers among 100 measurements (22.00%)
20 (20.00%) low mild
2 (2.00%) high mild
4096 string(10, 0) - 128
time: [120.30 µs 120.46 µs 120.62 µs]
change: [-0.4443% -0.3186% -0.1828%] (p = 0.00 <
0.05)
Change within noise threshold.
4096 string(10, 0) - 1024
time: [100.84 µs 100.87 µs 100.90 µs]
change: [-0.1108% -0.0352% +0.0550%] (p = 0.38 >
0.05)
No change in performance detected.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe
4096 string(10, 0) - 4096
time: [109.47 µs 110.80 µs 112.02 µs]
change: [-3.6030% -2.7357% -1.9150%] (p = 0.00 <
0.05)
Performance has improved.
4096 string(30, 0) - 128
time: [199.71 µs 199.81 µs 199.90 µs]
change: [-0.1739% -0.0899% -0.0088%] (p = 0.04 <
0.05)
Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe
4096 string(30, 0) - 1024
time: [178.48 µs 178.53 µs 178.59 µs]
change: [-0.0855% +0.0097% +0.0933%] (p = 0.84 >
0.05)
No change in performance detected.
Found 8 outliers among 100 measurements (8.00%)
5 (5.00%) high mild
3 (3.00%) high severe
4096 string(30, 0) - 4096
time: [189.35 µs 190.53 µs 191.52 µs]
change: [-3.7107% -2.9717% -2.3294%] (p = 0.00 <
0.05)
Performance has improved.
4096 string(100, 0) - 128
time: [430.35 µs 430.69 µs 431.08 µs]
change: [-0.0244% +0.0797% +0.1834%] (p = 0.13 >
0.05)
No change in performance detected.
Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high mild
4096 string(100, 0) - 1024
time: [465.68 µs 469.26 µs 472.13 µs]
change: [-2.7082% -1.3919% -0.1599%] (p = 0.03 <
0.05)
Change within noise threshold.
Found 23 outliers among 100 measurements (23.00%)
20 (20.00%) low severe
3 (3.00%) low mild
4096 string(100, 0) - 4096
time: [436.40 µs 437.63 µs 438.81 µs]
change: [+0.1291% +0.4030% +0.6693%] (p = 0.00 <
0.05)
Change within noise threshold.
Found 13 outliers among 100 measurements (13.00%)
12 (12.00%) low mild
1 (1.00%) high mild
4096 string(100, 0.5) - 128
time: [310.80 µs 310.96 µs 311.13 µs]
change: [-0.6979% -0.5621% -0.4446%] (p = 0.00 <
0.05)
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe
4096 string(100, 0.5) - 1024
time: [299.95 µs 301.09 µs 302.20 µs]
change: [-1.3131% -0.8438% -0.3311%] (p = 0.00 <
0.05)
Change within noise threshold.
4096 string(100, 0.5) - 4096
time: [300.49 µs 302.11 µs 303.68 µs]
change: [-2.2359% -1.6753% -1.1472%] (p = 0.00 <
0.05)
Performance has improved.
4096 string(20, 0.5), string(30, 0), string(100, 0), i64(0) - 128
time: [965.35 µs 966.12 µs 966.97 µs]
change: [-0.4355% +0.1689% +0.5690%] (p = 0.61 >
0.05)
No change in performance detected.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe
4096 string(20, 0.5), string(30, 0), string(100, 0), i64(0) - 1024
time: [920.97 µs 925.02 µs 929.03 µs]
change: [+1.4017% +2.0410% +2.6493%] (p = 0.00 <
0.05)
Performance has regressed.
4096 string(20, 0.5), string(30, 0), string(100, 0), i64(0) - 4096
time: [894.44 µs 900.48 µs 907.09 µs]
change: [+0.4112% +1.0848% +1.7978%] (p = 0.00 <
0.05)
Change within noise threshold.
Found 21 outliers among 100 measurements (21.00%)
19 (19.00%) high mild
2 (2.00%) high severe
4096 string(20, 0.5), string(30, 0), f64(0), i64(0) - 128
time: [802.37 µs 803.12 µs 803.87 µs]
change: [+3.9605% +4.1417% +4.3429%] (p = 0.00 <
0.05)
Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe
4096 string(20, 0.5), string(30, 0), f64(0), i64(0) - 1024
time: [732.96 µs 733.86 µs 734.95 µs]
change: [+3.7733% +3.9502% +4.1396%] (p = 0.00 <
0.05)
Performance has regressed.
Found 8 outliers among 100 measurements (8.00%)
2 (2.00%) high mild
6 (6.00%) high severe
4096 string(20, 0.5), string(30, 0), f64(0), i64(0) - 4096
time: [726.96 µs 728.58 µs 730.19 µs]
change: [+4.1967% +4.4437% +4.6878%] (p = 0.00 <
0.05)
Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
