judahrand commented on code in PR #34234:
URL: https://github.com/apache/arrow/pull/34234#discussion_r1319785287
##########
python/pyarrow/_acero.pyx:
##########
@@ -340,6 +340,78 @@ class HashJoinNodeOptions(_HashJoinNodeOptions):
)
+cdef class _AsofJoinNodeOptions(ExecNodeOptions):
+
+ def _set_options(self, left_on, left_by, right_on, right_by, tolerance):
+ cdef:
+ vector[CFieldRef] c_left_by
+ vector[CFieldRef] c_right_by
+ CAsofJoinKeys c_left_keys
+ CAsofJoinKeys c_right_keys
+ vector[CAsofJoinKeys] c_input_keys
+
+ # Prepare left AsofJoinNodeOption::Keys
+ if not isinstance(left_by, (list, tuple)):
+ left_by = [left_by]
+ for key in left_by:
+ c_left_by.push_back(_ensure_field_ref(key))
+
+ c_left_keys.on_key = _ensure_field_ref(left_on)
+ c_left_keys.by_key = c_left_by
+
+ c_input_keys.push_back(c_left_keys)
+
+ # Prepare right AsofJoinNodeOption::Keys
+ if not isinstance(right_by, (list, tuple)):
+ right_by = [right_by]
+ for key in right_by:
+ c_right_by.push_back(_ensure_field_ref(key))
+
+ c_right_keys.on_key = _ensure_field_ref(right_on)
+ c_right_keys.by_key = c_right_by
+
+ c_input_keys.push_back(c_right_keys)
+
+ self.wrapped.reset(
+ new CAsofJoinNodeOptions(
+ c_input_keys,
+ tolerance,
+ )
+ )
+
+
+class AsofJoinNodeOptions(_AsofJoinNodeOptions):
+ """
+ Make a node which implements 'as of join' operation.
+
+ This is the option class for the "asofjoin" node factory.
+
+ Parameters
+ ----------
+ left_on : str, Expression
+ The left key on which the join operation should be performed.
+ Can be a string column name or a field expression.
+ left_by: str, Expression or list[str]
+ The left keys on which the join operation should be performed.
+ Each key can be a string column name or a field expression,
+ or a list of such field references.
+ right_operand : Table or Dataset
+ The right operand for the join operation.
Review Comment:
https://github.com/apache/arrow/pull/34234/commits/6f8db25fec78546e19c91e405a3f1c14a0ddcd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
