Weijun-H commented on PR #4785:
URL: https://github.com/apache/arrow-rs/pull/4785#issuecomment-1713921457
> I think a 30% performance regression is a pretty tough sell, especially
when it isn't as if lexical_core has security vulnerabilities that impact us...
Have you tried the trick of using serde_json to provide the vended lexical_core?
The performance of `serde_json` also decreased.
```rust
small_bench_primitive time: [7.6051 µs 7.6808 µs 7.7639 µs]
change: [+20.123% +20.691% +21.386%] (p = 0.00 <
0.05)
Performance has regressed.
Found 10 outliers among 100 measurements (10.00%)
4 (4.00%) high mild
6 (6.00%) high severe
Benchmarking large_bench_primitive: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase
target time to 9.7s, enable flat sampling, or reduce sample count to 50.
large_bench_primitive time: [1.9096 ms 1.9123 ms 1.9155 ms]
change: [+4.5542% +4.8926% +5.1944%] (p = 0.00 <
0.05)
Performance has regressed.
Found 11 outliers among 100 measurements (11.00%)
4 (4.00%) high mild
7 (7.00%) high severe
small_bench_list time: [13.844 µs 13.870 µs 13.896 µs]
change: [+14.486% +15.117% +15.654%] (p = 0.00 <
0.05)
Performance has regressed.
Found 7 outliers among 100 measurements (7.00%)
4 (4.00%) high mild
3 (3.00%) high severe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
