lidavidm commented on code in PR #1049:
URL: https://github.com/apache/arrow-adbc/pull/1049#discussion_r1321761693
##########
.github/workflows/native-unix.yml:
##########
@@ -169,22 +169,30 @@ jobs:
mamba install -c conda-forge \
--file ci/conda_env_cpp.txt
+ - name: Export ASAN/UBSAN environment variables
+ shell: bash -l {0}
+ run: |
+ echo
"ASAN_OPTIONS=detect_leaks=0:symbolize=1:strict_init_order=true:allocator_may_return_null=1:halt_on_error=1"
>> "$GITHUB_ENV"
+ echo "LD_PRELOAD=$(gcc --print-file-name=libasan.so)" >>
"$GITHUB_ENV"
- name: Build SQLite3 Driver
shell: bash -l {0}
run: |
- env BUILD_ALL=0 BUILD_DRIVER_SQLITE=1 ./ci/scripts/cpp_build.sh
"$(pwd)" "$(pwd)/build"
+ env BUILD_ALL=0 BUILD_DRIVER_SQLITE=1 ADBC_USE_ASAN=1
ADBC_USE_UBSAN=1 \
+ ./ci/scripts/cpp_build.sh "$(pwd)" "$(pwd)/build"
Review Comment:
So, since the default is to enable ASAN, these tests already were using
ASAN/UBSAN.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
