alamb commented on PR #7401: URL: https://github.com/apache/arrow-datafusion/pull/7401#issuecomment-1714394309
> Since, I was working on fixing the GROUP BY, I added code to convert back utf8 arrays into dict arrays in the GroupedHashAggregateStream. I think if we do something similar for the other exec nodes that deal with the cardinality aware row converter, we should be good. @JayjeetAtGithub I think we should try and move this logic into `CardinalityAwareRowConverter` itself -- that way we don't have to replicate the logic in multiple exec nodes (and any future users will get it for free). I also think @tustvold has some plan to do the reconversion directly in the `RowConverter` -- I will work on sorting out / finding a ticket reference tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
