tustvold commented on code in PR #4707:
URL: https://github.com/apache/arrow-rs/pull/4707#discussion_r1322118858
##########
arrow-arith/src/arity.rs:
##########
@@ -105,10 +105,11 @@ where
let dict_values = array.values().as_any().downcast_ref().unwrap();
let values = try_unary::<T, F, T>(dict_values, op)?;
- Ok(Arc::new(array.with_values(&values)))
+ Ok(Arc::new(array.with_values(Arc::new(values))))
}
/// Applies an infallible unary function to an array with primitive values.
+#[deprecated(note = "Use arrow_array::AnyDictionaryArray")]
Review Comment:
I suppose we could add a function like
```
fn unary_dyn(a: &dyn Array, f: F) -> Result<ArrayRef, ArrowError>
where F: Fn(&dyn Array) -> Result<ArrayRef, ArrowError> {
...
}
```
But it just seems a tad confusing, for `f` to be a function supporting array
types, apart from dictionary arrays?
Perhaps you could expand on how you are using this kernel? It sees no usage
in arrow-rs nor DataFusion...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
