wjones127 commented on PR #7526: URL: https://github.com/apache/arrow-datafusion/pull/7526#issuecomment-1714705784
These seems good. I would also add: change `get_datatype` to just `datatype` to be more idiomatic. The other change I was wondering about is whether Display could be implemented to output the set notation representation. Would be cool to get something like `[10, 20]`, `[10, ∞)`, `(-∞, 100]` or `(-∞, ∞)` back. But if we don't feel like that's idiomatic Rust, we should at least change the representation so it indicates whether the bounds are open or closed. Right now the Display implementation for `IntervalBound` just uses `value`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
