alamb commented on code in PR #7467:
URL: https://github.com/apache/arrow-datafusion/pull/7467#discussion_r1323119572
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -129,6 +139,7 @@ impl<S: SimplifyInfo> ExprSimplifier<S> {
expr.rewrite(&mut const_evaluator)?
.rewrite(&mut simplifier)?
.rewrite(&mut or_in_list_simplifier)?
+ .rewrite(&mut guarantee_rewriter)?
// run both passes twice to try an minimize simplifications that
we missed
.rewrite(&mut const_evaluator)?
.rewrite(&mut simplifier)
Review Comment:
This is a neat idea. I think we should try it in a follow on PR.
ALso, If we did this I would also suggest adding a limit on the number of
loops (to avoid a "ping-poing" infinite loop where passes rewrite an expression
back and forth)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
