lidavidm commented on code in PR #37689:
URL: https://github.com/apache/arrow/pull/37689#discussion_r1324774633
##########
cpp/src/arrow/flight/transport/grpc/grpc_server.cc:
##########
@@ -598,7 +598,7 @@ class GrpcServerTransport : public
internal::ServerTransport {
} else if (scheme == kSchemeGrpcUnix) {
std::stringstream address;
address << "unix:" << uri.path();
- builder.AddListeningPort(address.str(),
::grpc::InsecureServerCredentials());
Review Comment:
Looks like this needs to be done above as well for the TLS branch
##########
cpp/src/arrow/flight/transport/grpc/grpc_server.cc:
##########
@@ -598,7 +598,7 @@ class GrpcServerTransport : public
internal::ServerTransport {
} else if (scheme == kSchemeGrpcUnix) {
std::stringstream address;
address << "unix:" << uri.path();
- builder.AddListeningPort(address.str(),
::grpc::InsecureServerCredentials());
Review Comment:
Plus, for domain sockets, port will still be 0 right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
