jorisvandenbossche commented on pull request #8894: URL: https://github.com/apache/arrow/pull/8894#issuecomment-754857132
The python failure looks legit: ``` ________________________ test_expression_serialization _________________________ def test_expression_serialization(): a = ds.scalar(1) b = ds.scalar(1.1) c = ds.scalar(True) d = ds.scalar("string") e = ds.scalar(None) f = ds.scalar({'a': 1}) g = ds.scalar(pa.scalar(1)) all_exprs = [a, b, c, d, e, f, g, a == b, a > b, a & b, a | b, ~c, d.is_valid(), a.cast(pa.int32(), safe=False), a.cast(pa.int32(), safe=False), a.isin([1, 2, 3]), ds.field('i64') > 5, ds.field('i64') == 5, ds.field('i64') == 7] for expr in all_exprs: assert isinstance(expr, ds.Expression) restored = pickle.loads(pickle.dumps(expr)) > assert expr.equals(restored) E assert False E + where False = <built-in method equals of pyarrow._dataset.Expression object at 0x7effd5d024a0>(<pyarrow.dataset.Expression is_in(1, value_set=[\n -2459565876494606883,\n -2459565876494606883,\n -2459565876494606883\n], skip_nulls)>) E + where <built-in method equals of pyarrow._dataset.Expression object at 0x7effd5d024a0> = <pyarrow.dataset.Expression is_in(1, value_set=[\n 1,\n 2,\n 3\n], skip_nulls)>.equals opt/conda/envs/arrow/lib/python3.8/site-packages/pyarrow/tests/test_dataset.py:419: AssertionError ``` Seems that the `value_set` is viewed/deserialized with a wrong type or so. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org