alamb opened a new pull request, #4815:
URL: https://github.com/apache/arrow-rs/pull/4815

   # Which issue does this PR close?
   
   Closes https://github.com/apache/arrow-rs/pull/4800
   Closes https://github.com/apache/arrow-rs/issues/4799
   
   
   # Rationale for this change
    
   Per discussion on https://github.com/apache/arrow-rs/issues/4801, this PR 
stops validating that schemas of the concatenated batches are exactly equal and 
instead uses the provided schema
   
   While this may hide some subtle bugs in downstream crates, it avoids 
arrow-rs enforcing an invariant (e.g. that schema equality also includes field 
metadata) that is not in other downstream crates
   
   Note that mismatched types still generate a useful error message which 
should catch any egrious errors. 
   
   # What changes are included in this PR?
   1. Remove the check for schema equality
   2. Update existing test
   3. Add new test showing what happens with mismatched types 
   <!--
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to