crepererum commented on code in PR #7554:
URL: https://github.com/apache/arrow-datafusion/pull/7554#discussion_r1325637118
##########
datafusion/physical-expr/src/intervals/interval_aritmetic.rs:
##########
@@ -1785,4 +1792,20 @@ mod tests {
Ok(())
}
+
+ #[test]
+ fn test_interval_display() {
Review Comment:
Both test cases result in `(...]`, i.e. they don't really cover the if-else
clauses within the formatter. I think having the 4 permutations (`(...)`,
`[...)`, `[...]`, `(...]`) would be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
