kazuyukitanimura commented on PR #7400: URL: https://github.com/apache/arrow-datafusion/pull/7400#issuecomment-1719856132
Thank you for all the benchmarks! Glad to see there is no degradation. > Do these benchmarks test the case of spilling? > > It would be very nice if we can do some tests like in this PR: [duckdb/duckdb#7931](https://github.com/duckdb/duckdb/pull/7931), which measures how performance may degrade as memory budget becomes lower. Thanks, though the intent of the benchmarks were to make sure this PR does not depredate, I agree that it is nice to to measure the performance under different memory pressure. Since this is the first PR for spilling, how about we do it for the future PRs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
