felipecrv commented on code in PR #37468:
URL: https://github.com/apache/arrow/pull/37468#discussion_r1326379962


##########
go/arrow/array/concat.go:
##########
@@ -483,6 +587,18 @@ func concat(data []arrow.ArrayData, mem memory.Allocator) 
(arr arrow.ArrayData,
                if err != nil {
                        return nil, err
                }
+       case *arrow.ListViewType:
+               offsetType := 
arrow.PrimitiveTypes.Int32.(arrow.FixedWidthDataType)

Review Comment:
   ```go
                offsetType := arrow.PrimitiveTypes.Int32
                err := concatListView(data, offsetType, out, mem)
   ```
   
   I get an error when I do this. Maybe the cast is not even valid (?) in the 
first place?
   
   `cannot use offsetType (variable of type arrow.DataType) as 
arrow.FixedWidthDataType value in argument to concatListView: arrow.DataType 
does not implement arrow.FixedWidthDataType (missing method BitWidth)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to