amoeba commented on PR #37698: URL: https://github.com/apache/arrow/pull/37698#issuecomment-1720005117
Those three suggestions look correct to me @nealrichardson, thanks for catching them. @thisisnic I sent you a PR on your fork at https://github.com/thisisnic/arrow/pull/10 with @nealrichardson 's suggestions and also one other fix. To test this out, I needed a way to make the build fail which I did by setting the libarrow install dir (`DEST_DIR`) to a non-existent directory. This makes the libarrow build fail at the install step. I didn't test my re-creating other types of common build issues but I think since we're printing everything this is enough of a test for this PR. The output of that run looks good to me and can be seen in [my gist](https://gist.github.com/amoeba/586ffd1972a1341e3937816302af5e6a). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
