alamb commented on PR #7432: URL: https://github.com/apache/arrow-datafusion/pull/7432#issuecomment-1720156346
> I think this is probably fine, however, I think we probably shouldn't make fields of *Exec public, this is a very strong API commitment and quite hard to later evolve/retract. I additionally think some of the duplication of test utilities could be reduced by adding them to datafusion-common, perhaps with #[doc(hidden)]. I have made both these changes -- I think the PR is substantially nicer because of it. Thank you again for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
