Weijun-H commented on code in PR #7568:
URL: https://github.com/apache/arrow-datafusion/pull/7568#discussion_r1327434750
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -883,14 +883,14 @@ mod test {
fn scalar_function() -> Result<()> {
let empty = empty();
let lit_expr = lit(10i64);
- let fun: BuiltinScalarFunction = BuiltinScalarFunction::Abs;
+ let fun: BuiltinScalarFunction = BuiltinScalarFunction::Acos;
Review Comment:
How about the keep this change?
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -883,14 +883,14 @@ mod test {
fn scalar_function() -> Result<()> {
let empty = empty();
let lit_expr = lit(10i64);
- let fun: BuiltinScalarFunction = BuiltinScalarFunction::Abs;
+ let fun: BuiltinScalarFunction = BuiltinScalarFunction::Acos;
Review Comment:
How about keeping this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
