tustvold commented on code in PR #4818:
URL: https://github.com/apache/arrow-rs/pull/4818#discussion_r1327514730
##########
arrow-array/src/types.rs:
##########
@@ -1368,12 +1368,14 @@ pub(crate) mod bytes {
}
impl ByteArrayNativeType for [u8] {
+ #[inline]
Review Comment:
That hasn't been my experience, I believe `#[inline]` makes the data
available to be inlined should LLVM think it a good idea, with
`'[inline(always)]` only necessary when LLVM doesn't think it a good idea (for
whatever reason).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
