danepitkin commented on code in PR #37097:
URL: https://github.com/apache/arrow/pull/37097#discussion_r1328753329
##########
python/pyarrow/_dataset.pyx:
##########
@@ -1075,10 +1075,11 @@ cdef class FileSystemDataset(Dataset):
self.partition_expression
)
- @classmethod
- def from_paths(cls, paths, schema=None, format=None,
- filesystem=None, partitions=None, root_partition=None):
- """A Dataset created from a list of paths on a particular filesystem.
+ @staticmethod
+ def from_paths(paths, schema=None, format=None, filesystem=None,
+ partitions=None, root_partition=None):
Review Comment:
classmethod does work, I can change it back. I tried switching to
staticmethod when numpydocs were failing, but it turns out it was the comment
that was causing numpydoc parsing errors. I thought staticmethod was a slight
improvement since `cls` wasn't actually used in the classmethod.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
