tustvold commented on code in PR #4832:
URL: https://github.com/apache/arrow-rs/pull/4832#discussion_r1329204605
##########
arrow-string/src/like.rs:
##########
@@ -155,20 +155,17 @@ fn apply<O: OffsetSizeTrait>(
) -> Result<BooleanArray, ArrowError> {
let l_len = l_v.map(|l| l.len()).unwrap_or(l.len());
if r_s {
- let scalar = match r_v {
- Some(dict) => match dict.nulls().filter(|n| n.null_count() != 0) {
Review Comment:
The bug is for the non-dictionary case we didn't check nullability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
