alamb commented on code in PR #4833:
URL: https://github.com/apache/arrow-rs/pull/4833#discussion_r1329300060
##########
arrow-select/src/dictionary.rs:
##########
@@ -330,4 +333,15 @@ mod tests {
assert_eq!(&merged.key_mappings[0], &[0, 0, 0, 1, 0]);
assert_eq!(&merged.key_mappings[1], &[]);
}
+
+ #[test]
Review Comment:
I verified that without the changes in this PR this test fails like this:
```
thread 'dictionary::tests::test_merge_keys_smaller' panicked at 'assertion
failed: `(left == right)`
left: `StringArray
[
]`,
right: `StringArray
[
"b",
]`', arrow-select/src/dictionary.rs:342:9
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
