alamb opened a new issue, #7600:
URL: https://github.com/apache/arrow-datafusion/issues/7600

   ### Is your feature request related to a problem or challenge?
   
   As the datafusion codebase gets bigger, finding tests is more and more 
important. 
   
   The location of the protobuf serialization roundtrip tests make them a 
little hard to find, see 
https://github.com/apache/arrow-datafusion/pull/7557#issuecomment-1724888236  
-- they are library tests but not in the module of the code
   
   In addition, by being in a library test the serialization code has access to 
some internal crate things that would not be accessable to users of the crate. 
Thus making a test binary would better cover the intended use
   
   
   ### Describe the solution you'd like
   
   I think we should move the tests into their own test binary 
`datafusion/proto/tests/proto_integration.rs`
   
   Following the model of 
https://github.com/apache/arrow-datafusion/blob/main/datafusion/substrait/tests/substrait_integration.rs
   
   Ideally, it would be split into logical and physical cases like: 
https://github.com/apache/arrow-datafusion/tree/main/datafusion/substrait/tests/cases
   
   
   ### Describe alternatives you've considered
   
   do nothing
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to