pitrou commented on code in PR #37769: URL: https://github.com/apache/arrow/pull/37769#discussion_r1330250291
########## dev/archery/archery/integration/tester.py: ########## @@ -17,12 +17,180 @@ # Base class for language-specific integration test harnesses +from abc import ABC, abstractmethod +import os import subprocess +import typing from .util import log -class Tester(object): +_Predicate = typing.Callable[[], bool] + + +class CDataExporter(ABC): + + @abstractmethod + def export_schema_from_json(self, json_path: os.PathLike, + c_schema_ptr: object): + """ + Read a JSON integration file and export its schema. + + Parameters + ---------- + json_path : Path + Path to the JSON file + c_schema_ptr : cffi pointer value + Pointer to the ``ArrowSchema`` struct to export to. + """ + + @abstractmethod + def export_batch_from_json(self, json_path: os.PathLike, + num_batch: int, + c_array_ptr: object): + """ + Read a JSON integration file and export one of its batches. + + Parameters + ---------- + json_path : Path + Path to the JSON file + num_batch : int + Number of the record batch in the JSON file + c_schema_ptr : cffi pointer value + Pointer to the ``ArrowArray`` struct to export to. + """ + + @property + @abstractmethod + def supports_releasing_memory(self) -> bool: + """ + Whether the implementation is able to release memory deterministically. + + Here, "release memory" means that, after the `release` callback of + a C Data Interface export is called, `compare_allocation_state` is + able to trigger the deallocation of the memory underlying the export + (for example buffer data). + + If false, then `record_allocation_state` and `compare_allocation_state` + are allowed to raise NotImplementedError. + """ + + def record_allocation_state(self) -> object: + """ + Record the current memory allocation state. + + Returns + ------- + state : object + Opaque object representing the allocation state, + for example the number of allocated bytes. + """ + raise NotImplementedError + + def compare_allocation_state(self, recorded: object, + gc_until: typing.Callable[[_Predicate], bool] Review Comment: I'll go with the current version. This can evolve quite easily as this is internal tooling, so no API guarantees. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
