bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r552837218



##########
File path: cpp/src/arrow/compute/kernels/util_internal.h
##########
@@ -50,6 +54,12 @@ int GetBitWidth(const DataType& type);
 // rather than duplicating compiled code to do all these in each kernel.
 PrimitiveArg GetPrimitiveArg(const ArrayData& arr);
 
+// Augment a unary ArrayKernelExec which supports only array-like inputs with 
support for
+// scalar inputs. Scalars will be transformed to 1-long arrays which are 
passed to the
+// original exec. This could be far more efficient, but instead of optimizing 
this it'd be
+// better to support scalar inputs "upstream" in original exec.

Review comment:
       Will do




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to