bkietz commented on code in PR #37793:
URL: https://github.com/apache/arrow/pull/37793#discussion_r1330792575
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -104,11 +104,12 @@ parquet::ArrowReaderProperties MakeArrowReaderProperties(
return arrow_properties;
}
-template <typename M>
Result<std::shared_ptr<SchemaManifest>> GetSchemaManifest(
- const M& metadata, const parquet::ArrowReaderProperties& properties) {
+ const parquet::FileMetaData& metadata,
+ const parquet::ArrowReaderProperties& properties) {
auto manifest = std::make_shared<SchemaManifest>();
- const std::shared_ptr<const ::arrow::KeyValueMetadata>& key_value_metadata =
nullptr;
Review Comment:
:grimacing:
##########
cpp/src/arrow/dataset/file_parquet_test.cc:
##########
@@ -703,6 +707,25 @@ TEST_P(TestParquetFileFormatScan,
PredicatePushdownRowGroupFragmentsUsingStringC
CountRowGroupsInFragment(fragment, {0, 3}, equal(field_ref("x"),
literal("a")));
}
+TEST_P(TestParquetFileFormatScan,
PredicatePushdownRowGroupFragmentsUsingDurationColumn) {
+ auto table = TableFromJSON(schema({field("t", duration(TimeUnit::NANO))}),
Review Comment:
Would you mind also checking for time32 since that was mentioned in the
issue? If it isn't fixed by this patch then we should make a follow up issue to
address it
```suggestion
for (auto type : {duration(TimeUnit::NANO), time32(TimeUnit::SECOND)}) {
auto table = TableFromJSON(schema({field("t", type)}),
```
Also, please describe the bug in GH-37111 and how this test checks it
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -104,11 +104,12 @@ parquet::ArrowReaderProperties MakeArrowReaderProperties(
return arrow_properties;
}
-template <typename M>
Result<std::shared_ptr<SchemaManifest>> GetSchemaManifest(
Review Comment:
Nice! I wonder when that became unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
