[GitHub] [arrow] R-JunmingChen commented on a diff in pull request #36739: GH-36420: [C++] Add An Enum Option For SetLookup Options

Tue, 19 Sep 2023 21:01:42 -0700 


R-JunmingChen commented on code in PR #36739:
URL: https://github.com/apache/arrow/pull/36739#discussion_r1330949943


##########
cpp/src/arrow/compute/api_scalar.cc:
##########
@@ -344,7 +367,8 @@ static auto kRoundToMultipleOptionsType = 
GetFunctionOptionsType<RoundToMultiple
     DataMember("round_mode", &RoundToMultipleOptions::round_mode));
 static auto kSetLookupOptionsType = GetFunctionOptionsType<SetLookupOptions>(
     DataMember("value_set", &SetLookupOptions::value_set),
-    DataMember("skip_nulls", &SetLookupOptions::skip_nulls));
+    DataMember("skip_nulls", &SetLookupOptions::skip_nulls),
+    DataMember("null_matching_behavior", 
&SetLookupOptions::null_matching_behavior));

Review Comment:
   
![image](https://github.com/apache/arrow/assets/18380073/6ffb667a-863f-4a30-9f87-747d9b553b59)
   Hi, here's an error I have no idea how to handle it when I put it to 
`reflection_internal.h`. Do you have any solution about it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to