thisisnic commented on code in PR #37781:
URL: https://github.com/apache/arrow/pull/37781#discussion_r1331704589
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -329,7 +329,8 @@ if("${BUILD_WARNING_LEVEL}" STREQUAL "CHECKIN")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wno-sign-conversion")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wunused-result")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wdate-time")
- elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Intel")
+ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Intel" OR CMAKE_CXX_COMPILER_ID
STREQUAL
+ "IntelLLVM")
Review Comment:
I hope you don't mind, but I'm going to merge the PR as I need it to
cherry-pick into an R package release I'm doing today, but we could make this
change in a follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
