tschaub commented on code in PR #37786:
URL: https://github.com/apache/arrow/pull/37786#discussion_r1331796409
##########
go/parquet/file/file_writer.go:
##########
@@ -30,21 +30,19 @@ import (
// Writer is the primary interface for writing a parquet file
type Writer struct {
- sink utils.WriteCloserTell
- open bool
- props *parquet.WriterProperties
- rowGroups int
- nrows int
- metadata metadata.FileMetaDataBuilder
- fileEncryptor encryption.FileEncryptor
- rowGroupWriter *rowGroupWriter
+ sink utils.WriteCloserTell
+ open bool
+ props *parquet.WriterProperties
+ rowGroups int
+ nrows int
+ metadata metadata.FileMetaDataBuilder
+ fileEncryptor encryption.FileEncryptor
+ rowGroupWriter *rowGroupWriter
+ initialKeyValueMetadata metadata.KeyValueMetadata
Review Comment:
@zeroshade - I'm happy to make the change to the `WriteOption` interface if
you think that makes sense. I wasn't sure how much of a breaking change would
be acceptable.
I could add
https://github.com/tschaub/arrow/commit/9e5f7c192266deeea1c2b7d34dbf11495391a10f
to this branch if that sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
