alamb commented on code in PR #4838:
URL: https://github.com/apache/arrow-rs/pull/4838#discussion_r1332143184
##########
arrow-array/src/array/mod.rs:
##########
@@ -173,52 +173,60 @@ pub trait Array: std::fmt::Debug + Send + Sync {
/// ```
fn offset(&self) -> usize;
- /// Returns the null buffer of this array if any
+ /// Returns the null buffer of this array if any.
///
- /// Note: some arrays can encode their nullability in their children, for
example,
+ /// The null buffer encodes the "physical" nulls of an array and is
pre-computed and very efficient.
+ /// However, some arrays can also encode nullability in their children,
for example,
Review Comment:
You are right re "pre-computed" I was trying to emphasize the non ergnomic
API was primarily for performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
