alamb commented on PR #7610: URL: https://github.com/apache/arrow-datafusion/pull/7610#issuecomment-1729342313
> I did not fix a bug, just prevented spamming the yield_now() for bounded output cases even if we have FIFO-like sinks since the data will eventually be written when the execution finishes. I am sorry -- I missed this point. > Do you have any suggestions on how to test this addition for better clarity? Given it is a performance optimization, perhaps we could just add a comment to the code explaining the rationale (so someone is less likely to remove it / break it accidentally) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
