alamb commented on code in PR #7614:
URL: https://github.com/apache/arrow-datafusion/pull/7614#discussion_r1334959880
##########
datafusion/physical-expr/src/datetime_expressions.rs:
##########
@@ -280,6 +323,7 @@ fn date_trunc_coarse(granularity: &str, value: i64) ->
Result<i64> {
fn _date_trunc(
tu: TimeUnit,
value: &Option<i64>,
+ tz: Arc<Option<Tz>>,
Review Comment:
I think a Tz is an integer
```rust
println!("Size of a Tz: {}",
std::mem::size_of::<arrow_array::timezone::Tz>());
```
Prints:
```
Size of a Tz: 4
```
So I think we can avoid this Arc. ~I'll make it a follow on PR~: Update PR
in https://github.com/apache/arrow-datafusion/pull/7630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
