viirya commented on code in PR #4830:
URL: https://github.com/apache/arrow-rs/pull/4830#discussion_r1335068516
##########
arrow-cast/src/cast.rs:
##########
@@ -8097,6 +8106,32 @@ mod tests {
test_cast_string_to_decimal(array);
}
+ #[test]
+ fn test_cast_string_to_decimal128_precision_overflow() {
Review Comment:
cast_string_to_decimal is not only for decimal128 but also for decimal256,
do you want to add a test for decimal256 too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
