kou commented on code in PR #37821:
URL: https://github.com/apache/arrow/pull/37821#discussion_r1335075583
##########
cpp/CMakePresets.json:
##########
@@ -46,6 +46,32 @@
"CMAKE_BUILD_TYPE": "RelWithDebInfo"
}
},
+ {
+ "name": "emscripten-overrides",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_BUILD_SHARED": "OFF",
+ "ARROW_BUILD_STATIC": "ON",
+ "ARROW_BUILD_TESTS": "OFF",
+ "ARROW_ENABLE_THREADING": "OFF",
+ "ARROW_CUDA": "OFF",
+ "ARROW_MIMALLOC": "OFF",
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_S3": "OFF",
+ "ARROW_DEPENDENCY_SOURCE": "BUNDLED",
+ "ZLIB_SOURCE": "SYSTEM",
+ "ARROW_IPC": "OFF",
+ "ARROW_ORC": "OFF",
+ "ARROW_SUBSTRAIT": "OFF",
+ "ARROW_DEPENDENCY_USE_SHARED": "OFF",
+ "ARROW_WITH_BROTLI": "OFF",
+ "ARROW_SIMD_LEVEL":"NONE",
+ "ARROW_RUNTIME_SIMD_LEVEL":"NONE",
+ "CMAKE_C_BYTE_ORDER":"LITTLE_ENDIAN",
+ "ARROW_WITH_OPENTELEMETRY":"OFF",
Review Comment:
```suggestion
"ARROW_WITH_OPENTELEMETRY": "OFF",
```
##########
cpp/CMakePresets.json:
##########
@@ -395,6 +421,16 @@
"displayName": "Release build for PyArrow with everything enabled",
"cacheVariables": {}
},
+ {
+ "name": "ninja-release-emscripten-python",
Review Comment:
How about renaming this to `ninja-release-python-emscripten` because we have
`ninja-release-python-maximal`?
##########
cpp/CMakePresets.json:
##########
@@ -46,6 +46,32 @@
"CMAKE_BUILD_TYPE": "RelWithDebInfo"
}
},
+ {
+ "name": "emscripten-overrides",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_BUILD_SHARED": "OFF",
+ "ARROW_BUILD_STATIC": "ON",
+ "ARROW_BUILD_TESTS": "OFF",
+ "ARROW_ENABLE_THREADING": "OFF",
+ "ARROW_CUDA": "OFF",
+ "ARROW_MIMALLOC": "OFF",
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_S3": "OFF",
+ "ARROW_DEPENDENCY_SOURCE": "BUNDLED",
+ "ZLIB_SOURCE": "SYSTEM",
Review Comment:
Could you sort this list in alphabetical order?
##########
cpp/CMakePresets.json:
##########
@@ -395,6 +421,16 @@
"displayName": "Release build for PyArrow with everything enabled",
"cacheVariables": {}
},
+ {
+ "name": "ninja-release-emscripten-python",
Review Comment:
How about adding `ninja-debug-emscripten` and `ninja-release-emscripten` too?
##########
cpp/CMakePresets.json:
##########
@@ -46,6 +46,32 @@
"CMAKE_BUILD_TYPE": "RelWithDebInfo"
}
},
+ {
+ "name": "emscripten-overrides",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_BUILD_SHARED": "OFF",
+ "ARROW_BUILD_STATIC": "ON",
+ "ARROW_BUILD_TESTS": "OFF",
+ "ARROW_ENABLE_THREADING": "OFF",
+ "ARROW_CUDA": "OFF",
+ "ARROW_MIMALLOC": "OFF",
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_S3": "OFF",
+ "ARROW_DEPENDENCY_SOURCE": "BUNDLED",
+ "ZLIB_SOURCE": "SYSTEM",
+ "ARROW_IPC": "OFF",
+ "ARROW_ORC": "OFF",
+ "ARROW_SUBSTRAIT": "OFF",
+ "ARROW_DEPENDENCY_USE_SHARED": "OFF",
+ "ARROW_WITH_BROTLI": "OFF",
+ "ARROW_SIMD_LEVEL":"NONE",
Review Comment:
```suggestion
"ARROW_SIMD_LEVEL": "NONE",
```
##########
cpp/CMakePresets.json:
##########
@@ -46,6 +46,32 @@
"CMAKE_BUILD_TYPE": "RelWithDebInfo"
}
},
+ {
+ "name": "emscripten-overrides",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_BUILD_SHARED": "OFF",
+ "ARROW_BUILD_STATIC": "ON",
+ "ARROW_BUILD_TESTS": "OFF",
+ "ARROW_ENABLE_THREADING": "OFF",
+ "ARROW_CUDA": "OFF",
+ "ARROW_MIMALLOC": "OFF",
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_S3": "OFF",
+ "ARROW_DEPENDENCY_SOURCE": "BUNDLED",
+ "ZLIB_SOURCE": "SYSTEM",
+ "ARROW_IPC": "OFF",
+ "ARROW_ORC": "OFF",
+ "ARROW_SUBSTRAIT": "OFF",
+ "ARROW_DEPENDENCY_USE_SHARED": "OFF",
+ "ARROW_WITH_BROTLI": "OFF",
+ "ARROW_SIMD_LEVEL":"NONE",
+ "ARROW_RUNTIME_SIMD_LEVEL":"NONE",
Review Comment:
```suggestion
"ARROW_RUNTIME_SIMD_LEVEL": "NONE",
```
##########
cpp/CMakePresets.json:
##########
@@ -46,6 +46,32 @@
"CMAKE_BUILD_TYPE": "RelWithDebInfo"
}
},
+ {
+ "name": "emscripten-overrides",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_BUILD_SHARED": "OFF",
+ "ARROW_BUILD_STATIC": "ON",
+ "ARROW_BUILD_TESTS": "OFF",
+ "ARROW_ENABLE_THREADING": "OFF",
+ "ARROW_CUDA": "OFF",
+ "ARROW_MIMALLOC": "OFF",
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_S3": "OFF",
+ "ARROW_DEPENDENCY_SOURCE": "BUNDLED",
+ "ZLIB_SOURCE": "SYSTEM",
+ "ARROW_IPC": "OFF",
+ "ARROW_ORC": "OFF",
+ "ARROW_SUBSTRAIT": "OFF",
+ "ARROW_DEPENDENCY_USE_SHARED": "OFF",
+ "ARROW_WITH_BROTLI": "OFF",
+ "ARROW_SIMD_LEVEL":"NONE",
+ "ARROW_RUNTIME_SIMD_LEVEL":"NONE",
+ "CMAKE_C_BYTE_ORDER":"LITTLE_ENDIAN",
Review Comment:
```suggestion
"CMAKE_C_BYTE_ORDER": "LITTLE_ENDIAN",
```
##########
cpp/CMakePresets.json:
##########
@@ -395,6 +421,16 @@
"displayName": "Release build for PyArrow with everything enabled",
"cacheVariables": {}
},
+ {
+ "name": "ninja-release-emscripten-python",
+ "inherits": [
+ "emscripten-overrides",
+ "base-release",
+ "features-python"
+ ],
+ "displayName": "Release build which builds an emscripten library, plus
PyArrow for Pyodide",
Review Comment:
Ah, we don't include any PyArrow related features in Arrow C++ now.
(GH-14117)
`features-python` is just for enabling Arrow C++ features that are used from
PyArrow.
##########
cpp/CMakePresets.json:
##########
@@ -46,6 +46,32 @@
"CMAKE_BUILD_TYPE": "RelWithDebInfo"
}
},
+ {
+ "name": "emscripten-overrides",
Review Comment:
How about rename this to `base-emscripten` or `features-emscripten`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
