jorisvandenbossche commented on code in PR #37624:
URL: https://github.com/apache/arrow/pull/37624#discussion_r1335837451
##########
dev/tasks/conda-recipes/arrow-cpp/meta.yaml:
##########
@@ -383,33 +377,31 @@ outputs:
# skip tests that raise SIGINT and crash the test suite
{% set tests_to_skip = tests_to_skip + " or (test_csv and
test_cancellation)" %} # [linux]
{% set tests_to_skip = tests_to_skip + " or (test_flight and
test_interrupt)" %} # [linux]
- # tests that may crash the agent due to out-of-bound memory writes or
other risky stuff
- {% set tests_to_skip = tests_to_skip + " or test_debug_memory_pool" %}
# [aarch64 or ppc64le]
- # cannot pass -D_LIBCPP_DISABLE_AVAILABILITY to test suite for our
older macos sdk
- {% set tests_to_skip = tests_to_skip + " or
test_cpp_extension_in_python" %} # [osx]
# skip tests that make invalid(-for-conda) assumptions about the
compilers setup
{% set tests_to_skip = tests_to_skip + " or test_cython_api" %}
# [unix]
{% set tests_to_skip = tests_to_skip + " or test_visit_strings" %}
# [unix]
# skip tests that cannot succeed in emulation
{% set tests_to_skip = tests_to_skip + " or
test_debug_memory_pool_disabled" %} # [aarch64 or ppc64le]
{% set tests_to_skip = tests_to_skip + " or
test_env_var_io_thread_count" %} # [aarch64 or ppc64le]
+ # XMinioInvalidObjectName on osx/win: "Object name contains
unsupported characters"
+ {% set tests_to_skip = tests_to_skip + " or
test_write_to_dataset_with_partitions_s3fs" %} # [osx or win]
# vvvvvvv TESTS THAT SHOULDN'T HAVE TO BE SKIPPED vvvvvvv
- {% set tests_to_skip = tests_to_skip + " or
test_extension_to_pandas_storage_type" %}
- # segfaults on OSX: to investigate ASAP
- {% set tests_to_skip = tests_to_skip + " or test_flight" %}
# [osx]
+ # currently broken
+ {% set tests_to_skip = tests_to_skip + " or
test_fastparquet_cross_compatibility" %}
Review Comment:
I took a closer look at it (could reproduce this locally), and so actually
it was good to do so, as this is a problem in fastparquet reading parquet files
generated by latest pyarrow, see details at
https://github.com/apache/arrow/issues/37853#issuecomment-1733422017
But yes, so skipping for now is perfectly fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
