thisisnic commented on issue #35994: URL: https://github.com/apache/arrow/issues/35994#issuecomment-1734042545
There are two different functions in the C++ codebase for copying files like this; see below https://github.com/apache/arrow/blob/1ae243628611a43812747f3bc1505072a139b1c8/cpp/src/arrow/filesystem/filesystem.h#L522-L542 We currently provide bindings to the second one, but not the first. https://github.com/apache/arrow/blob/1ae243628611a43812747f3bc1505072a139b1c8/r/src/filesystem.cpp#L276-L284 I think what we probably want to do here is create R bindings to the other `CopyFiles()` function, and then when someone uses the R `copy_files()` function, we check whether the input arguments are directories or not, and use that logic to decide which of the CopyFiles function bindings to call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
