lidavidm commented on code in PR #304:
URL: https://github.com/apache/arrow-nanoarrow/pull/304#discussion_r1336278089
##########
src/nanoarrow/array_test.cc:
##########
@@ -1695,7 +1694,7 @@ TEST(ArrayTest, ArrayViewTestString) {
// Check sequential offsets whose diff causes overflow
offsets[1] = 2080374784;
- offsets[2] = -2147483648;
+ offsets[2] = -static_cast<int64_t>(2147483648);
Review Comment:
could also do INT_MIN or `std::numeric_limits<int32_t>::min()`?
##########
src/nanoarrow/buffer_test.cc:
##########
@@ -290,12 +290,12 @@ void TestArrowBitmapUnpackUnsafe(const uint8_t* bitmap,
std::vector<int8_t> expe
EXPECT_EQ(out32[i], expected[i]);
}
}
-
+// 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
Review Comment:
Er...is this a token?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
