jorisvandenbossche commented on code in PR #36846:
URL: https://github.com/apache/arrow/pull/36846#discussion_r1336805745
##########
python/pyarrow/table.pxi:
##########
@@ -5042,9 +5043,14 @@ def concat_tables(tables, c_bool promote=False,
MemoryPool memory_pool=None):
tables : iterable of pyarrow.Table objects
Pyarrow tables to concatenate into a single Table.
promote : bool, default False
- If True, concatenate tables with null-filling and null type promotion.
+ If True, concatenate tables with null-filling and type promotion.
+ See field_merge_options for the type promotion behavior.
Review Comment:
> The problem is that the `promote` is only relevant when merging tables,
when just upcasting fields, then you don't need this, therefore `merge_options`
might not be the best place to put it.
Do you mean with "merging" tables for when the columns don't match? So if a
column is not present in one of the tables, it gets filled with all nulls. This
specific aspect is not something that you can control with
`field_merge_options`? (you can only control whether to upcast null type to the
target type, if the nulls where already present)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
