alamb commented on PR #7612: URL: https://github.com/apache/arrow-datafusion/pull/7612#issuecomment-1735340910
> I don't mind simplifying the code so I'll work on it following your earlier suggestions. Thank you! BTW I found the relevant code to extract equijoins predicates here: https://docs.rs/datafusion/latest/datafusion/optimizer/extract_equijoin_predicate/struct.ExtractEquijoinPredicate.html > are you thinking a new set of tests that specifically test for the absence of post_join_filter Yes I guess I was thinking about that. Mostly I was thinking "if we broke / reverted the code in this PR accidentally, how would we know something wasn't correct"? Without some test coverage the behavior could change and we don't know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
