Fokko commented on PR #36846: URL: https://github.com/apache/arrow/pull/36846#issuecomment-1735580099
I already implemented the logic of combining uints and ints, but there was a bug. I've fixed it and added some tests as well. > Numpy also seems to go to float when combining uint64 with any signed integer (since uint64 values cannot all be held in int64). Not sure if we should also do that .. I agree, that's a bit awkward. If it doesn't fit, we'll get an overflow exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
