tustvold commented on code in PR #4861:
URL: https://github.com/apache/arrow-rs/pull/4861#discussion_r1337343710
##########
arrow-json/src/reader/serializer.rs:
##########
@@ -115,43 +99,63 @@ impl<'a, 'b> Serializer for &'a mut TapeSerializer<'b> {
}
fn serialize_i8(self, v: i8) -> Result<(), SerializerError> {
- serialize_numeric!(self, i8, v)
+ self.serialize_i32(v as _)
}
fn serialize_i16(self, v: i16) -> Result<(), SerializerError> {
- serialize_numeric!(self, i16, v)
+ self.serialize_i32(v as _)
}
fn serialize_i32(self, v: i32) -> Result<(), SerializerError> {
- serialize_numeric!(self, i32, v)
+ self.elements.push(TapeElement::I32(v));
+ Ok(())
}
fn serialize_i64(self, v: i64) -> Result<(), SerializerError> {
- serialize_numeric!(self, i64, v)
+ let low = v as i32;
+ let high = (v >> 32) as i32;
+ self.elements.push(TapeElement::I64(high));
+ self.elements.push(TapeElement::I32(low));
+ Ok(())
}
fn serialize_u8(self, v: u8) -> Result<(), SerializerError> {
- serialize_numeric!(self, u8, v)
+ self.serialize_i32(v as _)
}
fn serialize_u16(self, v: u16) -> Result<(), SerializerError> {
- serialize_numeric!(self, u16, v)
+ self.serialize_i32(v as _)
}
fn serialize_u32(self, v: u32) -> Result<(), SerializerError> {
- serialize_numeric!(self, u32, v)
+ match i32::try_from(v) {
+ Ok(v) => self.serialize_i32(v),
+ Err(_) => self.serialize_i64(v as _),
+ }
}
fn serialize_u64(self, v: u64) -> Result<(), SerializerError> {
- serialize_numeric!(self, u64, v)
+ match i64::try_from(v) {
+ Ok(v) => self.serialize_i64(v),
+ Err(_) => {
+ let mut buffer = [0_u8; u64::FORMATTED_SIZE];
Review Comment:
Possibly, or as a u64 variant. Given JSON only reliably roundtrips f64, I
don't think this is a very common use-case worth optimising for
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
